Louis Chu
Louis Chu
Please make changes based on comments left on https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2076
Since index pattern management app also has order 0, do we have plan to reorder all apps together?
@zhongnansu My PR https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2510 contains some significant design updates. I'd appreciate it if we could get it finalized first.
> @noCharger Can we keep the diff limited to just the change? I know it can be tempting (or just an accident) to push in a bunch of other linting...
> One favor, could you mention the testing steps about how to reproduce the attack and expected error message? This way others know how to test as well. @kristenTian Reproduce...
Thanks team for the great feedbacks! I'll revise it and get back to you.
> One thing to consider is how the RM will use this document in concert with the release issue checklist - I could imagine that we update the template so...
@mpabba3003 is this done since https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2521 merged?
Do we need to update the snapshot as well?
Running single suite passed. ``` yarn test:jest src/plugins/data_source/server/cryptography/cryptography_client.test.ts yarn run v1.22.19 $ node scripts/jest src/plugins/data_source/server/cryptography/cryptography_client.test.ts PASS src/plugins/data_source/server/cryptography/cryptography_client.test.ts ✓ Invalid wrapping key size throws error (4 ms) Test encrpyt and decrypt...