Nikolai Morin
Nikolai Morin
I tried that, but curiously, it didn't change anything. On Wed, Nov 21, 2018, 18:23 Tian Jin Hi, the easiest fix is to make sure onnx-tf doesn't see your GPU's....
I'm sorry, the issue was shell-related. I use fish and ran `set -x CUDA_VISIBLE_DEVICES` instead of `set -x CUDA_VISIBLE_DEVICES ''`. When I do it correctly, it does not use the...
This can be done with https://github.com/frewsxcv/cargo-all-features, but probably we want to have a nightly job for that since it could take some time.
@esteve You suggested to remove the `*Handle` structs [here](https://github.com/ros2-rust/ros2_rust/pull/193#issuecomment-1148745743), and I think that makes sense. They are not useful for users, so removing them removes internal details from our public...
I'm okay with waiting for clients & services.
> How would that work with `GuardCondition`s? They are entities that are added to a waitset, but behave differently than subscriptions, clients, services, etc. In `rclcpp`, `ClientBase`, `SubscriptionBase` and `ServiceBase`...
@esteve I had an idea. Currently, after this PR, the `Node` would have members ```rust pub(crate) clients: Vec, pub(crate) services: Vec, pub(crate) subscriptions: Vec, ``` – same for the `WaitSet`....
I've applied the changes to `SubscriptionHandle`/`SubscriptionBase` also to clients and services. The diff is a bit large as a result – let me know if you'd prefer me to split...
> Good idea! I like it, in fact, that's the same class hierarchy as `rclcpp` wink I prefer to keep it as `ClientBase`, it'll be consistent with `rclcpp` > >...
I haven't done the clippy fixes from https://github.com/ros2-rust/ros2_rust/pull/247 in here, since I'm thinking that one can be merged relatively quickly.