nmscode
nmscode
I apologize for the issue with the repository. I have rebased it and I think that particular issue is fixed now.
> Thank you for the contribution, however this doesn't appear to be in a reviewable state at the moment: there's merge conflict chunks, incorrect indentation, linter errors, etc which all...
> @nmscode as per the docs, run `yarn i18n` to re-generate the internationalisation files I have tried this with and without my changes to en_EN.json but it still does not...
I reran it again and it is fine now.
@robintown @turt2live Here is the spec change proposal https://github.com/matrix-org/matrix-spec-proposals/pull/3892
Thank you @JiffyCat for the formatting/style fixes. Some points from the last review I wanted to address: To alleviate concerns about conflicting MSCs I have added a compatibility option which...
> @nmscode your code doesn't build nor pass the linters and tests. Sorry about that. The issues have been fixed. It should build and pass most linters/tests.
@t3chguy fixed errors with strict type checker
fixed conflict and merged
How do I check coverage locally for my changes when I am writing tests for them? I tried yarn test --coverage it gave me the report for the entire repo....