Victor Nakoryakov
Victor Nakoryakov
Hello, great thanks for maintaining this repo! I’d like to promote a new language grammar that is battle-tested enough to this repo, so that programmers who use ReScript can just...
Sure. What points should this PR affect? I see: - https://github.com/nvim-treesitter/nvim-treesitter/blob/master/lua/nvim-treesitter/parsers.lua - https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries - https://github.com/nvim-treesitter/nvim-treesitter/tree/master/tests/query/highlights Will it be enough?
> But you have only three parsers installed. How can the C++ tests pass when you don't have the parser installed? Oops. I didn’t thought about details that much :grin:...
Ouch, and the problem is not only in indents ``` $ ./scripts/run_tests.sh query/highlights_spec.lua Starting...Scheduling: tests/query/highlights_spec.lua ======================================== Testing: /home/nkrkv/devel/playground/nvim-treesitter/tests/query/highlights_spec.lua Fail || highlight queries tests/query/highlights/bash/double-parens.sh ...ayground/nvim-treesitter/tests/query/highlights_spec.lua:28: attempt to concatenate a nil value...
@kyazdani42 Yes. I just updated all the deps and tried again. The result is the same.
One thought about how could it look like. What if ReScript introduce an `@import` annotation that can be used like this: ```rescript let modulePromise = @import ModuleName.functionName // or later,...
> The example intends `@import` or `import` to transform the `Widget.make` to the component's path as a string. Is it your idea? Almost. I mean whenever I use `import` and...
Here’s my take https://github.com/nkrkv/nvim-treesitter-rescript
Thank you! > First look, one thing is missing is function definition and call. :thinking: they are here: - https://github.com/nkrkv/tree-sitter-rescript/blob/d4329e03a08f303deffe8856e48b0a0b6fdd05e8/grammar.js#L452-L455 - https://github.com/nkrkv/tree-sitter-rescript/blob/d4329e03a08f303deffe8856e48b0a0b6fdd05e8/grammar.js#L338-L348 Or do you mean their highlighting queries? >...
> I mean their highlight yeap I’m not sure how practical it is for FP-like language: ``` Array.map(myFunc) // Tree-sitter have no idea that myFunc is a function, so will...