Krishang

Results 8 comments of Krishang

Hey y'all 👋🏽 We're working on the next iteration of the Marketplace contract; you can track the effort, here: https://github.com/thirdweb-dev/contracts/pull/259 We've added explicit view functions such as `getAllListings` and `getAllValidListings`...

Hey @alfheimrShiven 👋🏽 same comment as https://github.com/thirdweb-dev/contracts/pull/567 could you please fix? Thanks!

Hey @0xShin0221 👋🏽 this is great, I'll find time to review your `VoteERC721` contract!

and looks like I'm a year late to the issue ...

>Created `HookParamSelector` component for selecting hook parameters Added `HookInputFieldset `for managing hook input fields The usage of "Hook" anywhere needs to be replaced with "Callback" -- we should use uniform...

Hi @gregorym 👋🏽 here's a user deployment of thirdweb's [MarketplaceV3 contract](https://github.com/thirdweb-dev/contracts/tree/main/contracts/prebuilts/marketplace), which is written in the dynamic contracts pattern and uses BaseRouter: https://thirdweb.com/polygon/0xdeDA3FF7C2293cd3426de2f6A79496f82b2928F6 The marketplace contract consists of a router,...

Hey @alfheimrShiven 👋🏽 I was looking to merge your PR, but looks like we updated some APIs (see attached screenshot) and the PR actions are failing. Could you correct them...

Hey @nmluthfi 👋🏽 Our AA bundler and Paymaster service is available only on select chains. And so, we've only enabled deployment of account factory contracts on these supported chains. I...