Norbert Kalmar
Norbert Kalmar
Hi @JiriOndrusek , Thanks for this patch and looking into this. Unfortunately there is no maven OSGi whatsoever, so it needs to be added. As this is not a regression,...
I agree with Enrico, please just continue on this branch, as maven will be used to release future 3.5.x and 3.6.x versions. I don't have much to add, but I'll...
There will be 2 jars upon release, zookeeper-jute and zookeeper-server. zookeeper-jute is the serialization library (just like protobuf). zookeeper-server depends on zookeeper-jute. Since jute (originally) was an independent project, it...
I see you changed zookeeper-server packaging from jar to bundle. Yeah... I will check up on this sometime this week. I'm afraid this also affects other things.
What I meant in "private package" is that we do not expose any of this to clients. Jute is only used to serialize messages between ZooKeeper nodes, client does not...
We would still need to solve it for 3.5 branch. So, for me, creating a zookeeper-osgi seems the way to go, but this should be voted on the zookeeper-dev mail...
Thanks @JiriOndrusek , I'll ping @eolivelli if he has anything to add, otherwise LGTM! I'll also check 3.5 fix...
@eolivelli you already reviewed the patch for 3.6, are we good to merge this?
Added title description, I'll leave the review to someone with more C knowledge :)
@meszibalu Can you please take a look?