Niek Jannink

Results 61 comments of Niek Jannink

Sorry I did not have time to look at it the last weeks. I will see if I can check next week

I can still reproduce the issue with version 1.1.1 of Blazorise, but I guess its not merged yet to that branch

![image](https://user-images.githubusercontent.com/3843546/194376581-babc0aea-8ee5-4a5e-868c-77db134715c8.png)

so no way for me to really test it in my setup. I did a code review and that looked fine

Yes I migrated to 1.1.1 for our dev environment. Our production is still 1.0. But since this exception is not really a blocker its fine to fix it for 1.1

If I look at the code then I can see there is a possible race condition: ``` 1. var moduleInstance = await Module; 2. await moduleInstance.InvokeVoidAsync( "registerBreakpointComponent", dotNetObjectRef, elementId );...

I see this construction everywhere so possibly everywhere this dispose race-condition could occur

Maybe a helper method for save invocation: ``` protected async ValueTask InvokeVoidSafeAsync( string identifier, params object[] args ) { if ( IsUnsafe ) return; var module = await moduleTask; if...

what would you like that happens on a JSDisconnectedException? Also return the default value?