Nitin Chhabra
Nitin Chhabra
Thanks @adutra for the insightful code review comments, really appreciate it. I'll address all of them and have an open question/clarification posted above.
Thanks @adutra for the code review, have addressed all the review comments.
Thanks @adutra for the code review and the suggestions, incorporated both of them. Would wait for @absurdfarce to let us know about CI tests.
Hey @adutra @absurdfarce Checking in, would the PR be accepted? As I see other PR: https://github.com/apache/cassandra-java-driver/pull/1907 getting merged 2 weeks back passing DataStax Jenkins, would appreciate if we know the...
Thanks @tolbertam and @absurdfarce for taking the time and helping to simplify the code with [refactored PR](https://github.com/absurdfarce/cassandra-java-driver/pull/1 ). I am not sure how the changes would be integrated, or should...
> @nitinitt Probably the most straightforward way to incorporate the changes would be to get a patch file from the other PR and then apply that patch to this PR....
Thanks @absurdfarce for the guidance and the patience. I have squashed and force pushed and here is how git log looks: ``` Author: Nitin Chhabra Date: Thu Nov 30 12:38:23...
Thanks @absurdfarce! I have addressed the 2 minor documentation comments as part of: https://github.com/apache/cassandra-java-driver/pull/1933/files