Satoshi Asano comments

Results 15 comments of


                                            Satoshi Asano

can i use NJKWebViewProgress in alone viewController, without navigation controller?

Yes. `NJKWebViewProgressView` is only UIView subclass and you can use your favourite progress view (such as UIProgressView).

Imprecise progress display

That's sounds nice. Pull requests are welcome! Does Facebook really use this technique? I think they used complementing with timer.

Custom font removed?

Thanks reporting. This issue will be fixed by https://github.com/ninjinkun/NJKScrollFullScreen/pull/7 . Please wait for merge.

Custom font removed?

@winkelsdorf Sorry to keep your waiting for merge #7. @xuzhe and me try to resolve it. If you can't wait for merge it, you can use @xuzhe 's version now....

Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly

Thanks. I will review it on this weekend.

Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly

@xuzhe I reviewed. Your pull request is almost looks good. Please reply to my comments.

Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly

@xuzhe If you are busy, I'll merge and fix it by myself. I'm waiting for your reply.

Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly

@xuzhe After re-review, I found problem https://github.com/ninjinkun/NJKScrollFullScreen/pull/7#discussion_r9794677 . I want to merge 7334d7fa799ddee52a516b231e75e7ba51919534. But other commits need discussion. If you OK, I will cherry pick 7334d7fa799ddee52a516b231e75e7ba51919534.

Progress issue with single page web app

@SPopenko Thanks reporting. I'll check that website.

Progress issue with single page web app

@SPopenko I've tried several times to access Toysrus site, and problem happened only one time. I'm looking for condition what caused this problem. Do you know how to represent it?