Ziwen Ning
Closing because of no response. Feel free to reopen.
If it reaches a super good value by transient issue for one time, will be "Best" be corrupted and it will consistently alert until you fix the data point manually?...
Closing because of no response. Feel free to reopen.
@TrungBui59 Thanks. Looks like your screenshot only covers the final summary of the failing e2e tests. Could you scroll up, find the verbose logs for each failing scenario, and paste...
There are 3 ways of filling host gateway IP in nerdctl: config, command arg and env var. Finch should also support all of them for feature parity. By default users...
Could you add e2e tests? The host-gateway-ip in finch config is under e2e/vm? Similar to https://github.com/runfinch/finch/blob/main/e2e/vm/additional_disk_test.go The host-gateway-ip arg and env var can be added in common-tests repo around here....
Please rename the PR to conventional commit message style to pass the PR title check. https://www.conventionalcommits.org/en/v1.0.0/
@TrungBui59 Reading the code, it seems passing it [here](https://github.com/runfinch/finch/blob/fef6e772c28429ef14068702c1dfd8e9fec2dea1/cmd/finch/virtual_machine.go#L93) should work. Have you tried it? What is the error?
> > One nit pick. Also need to fix the errors in CI. > > Others LGTM. > > Need a follow-up PR in https://github.com/runfinch/common-tests to test CLI flag and...
Could you make the PR title more accurate? Such as "feat: make host gateway ip configurable". The PR title will be the final commit message.