Nina Pypchenko
Nina Pypchenko
Can I confirm that the file naming conventions for TypeScript files are `.ts` for general code and `.tsx` for anything containing JSX-like syntax? The linked PRs seem to be following...
Thanks @datitisev, a PR is on the way. > Hm, if that's the source of the warning then that's a big facepalm for me. Feel free to PR to that...
Also, there are more warnings in the files that's already been converted to TypeScript. Wouldn't it be great if these were caught automatically by a GitHub action? ESLint has a...
Thanks @datitisev, I certainly don't have an intention of making any code ugly. Either way, I need to read up on Mithril and get a bit more comfortable with the...
@amosfolz, just a quick note to say that the ru_RU locale appears to be 100% complete and should be ticked off your list.
@tsteur, unit tests run fine without the `request_uri` specified, some integration and system tests run but many are skipped or are erroring out: ```bash ninap@localhost matomo]$ ./console tests:run --testsuite integration...
Regarding the need to run the Omnifixture script: an empty test database is not enough because there is a bug in the bootstrap code, originating in the prepareServerVariables() function: https://github.com/matomo-org/matomo/blob/4.x-dev/tests/PHPUnit/bootstrap.php#L81...
@tsteur, yes, I think that's what the bootstrap code is meant to do - to copy the DB credentials from the main DB and autoconfigure the `request_uri` parameter. I have...
> 5\. Realise that you did not actually want to change the user's display name > > > Now there is only the "OK" button with the check mark icon...
One thing that could be improved is tooltips - the round "tick" button has a "Done" tooltip while the arrows don't have anything. Perhaps a tooltip with "Save" could be...