Nikolaj Brask-Nielsen
Nikolaj Brask-Nielsen
### Prerequisites - [x] I have added steps to test this contribution in the description below If there's an existing issue for this PR then this fixes ### Description This...
### Which *exact* Umbraco version are you using? For example: 9.0.1 - don't just write v9 8.18.2 & 10.0.0-rc3 ### Bug summary It seems that the link insertion function that...
closes #857 This adds a cache step to the GitHub actions using `packages.lock.json` files. These files are generated on build and keep track of changes in the dependencies of projects....
Mentioned in #648 Specific issue: https://sonarcloud.io/project/issues?issues=AYPAuNd5hbfJOGLOoZ8u&open=AYPAuNd5hbfJOGLOoZ8u&id=nikcio_lucenenet (Solved) This can be removed and replaced with a comment `// LUCENENET specific - removed FSTEntry because it is not in use`. Similar issues...
Added a sonar cloud badge to the README to easily link the project sonar cloud page. This also helps convey the rated maintainability of the project. Looks: 
Mentioned in #648 Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS3247&id=apache_lucenenet SonarCloud includes a description on how to solve these issues. Use the "Why is this an issue?" link. No comment needed. This is more...
Mentioned in #648 Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS108&id=apache_lucenenet The comment associated with the line can be moved inside of the curly brackets to make it non-empty. If there is no comment, just...
Mentioned in #648 Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1117&id=apache_lucenenet We can fix this for the static readonly fields. In regular instance methods, we should leave it alone unless it diverges from Lucene.
Mentioned in #648 Specific issue: https://sonarcloud.io/project/issues?issues=AYRH0T92_qq9ReJdi431&open=AYRH0T92_qq9ReJdi431&id=apache_lucenenet Make it const Similar issues: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS2223&id=apache_lucenenet For `internal` members, try declaring `private`. But a compile will be required to test whether that is valid...
Mentioned in #648 Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS3928&id=apache_lucenenet This is a bug - we need to use the correct parameter name. For the analysis factories, using the name of a local variable...