Nikifor Seriakov

Results 14 comments of Nikifor Seriakov

I've tested it manually with a small program. But that feature definitely requires tests. So I'll add them when I manage how to do it.

This is how test function basically looks like. ``` auto server = new ss::httpd::http_server_control(); server->start("glutton_http").get(); server->set_routes(debug_sleep).get(); server->listen(port).get(); ll.info("HTTP server is listening on port {}", port); ssignal.wait().get(); ll.info("Signal received; shutting down");...

I've added tests, but I couldn't make it properly work. If the server stops before the client finishes its request, a broken pipe exception is raised, and even if caught,...

> Is there any difference between current implementation? It is equivalent for now but it's a time bomb if something changed. EDIT: I mean I made it more similar and...

> sorry , I can not quite get this, so what is the motivation for this PR? There is unified interface to work with database. It's defined in [rawdb package](https://github.com/binance-chain/bsc/blob/master/core/rawdb/schema.go)....

``` $ cat Procfile_db p1: pbin -logtostderr -http :6060 -addr :31337 -db "failover" -join :31337 --nodeid 0 p2: pbin -logtostderr -http :6061 -addr :31338 -db "failover" -join :31337 --nodeid 55...

``` nik@nik-msi@03:23:45:pdir$ goreman run stop p1 ^C nik@nik-msi@03:25:42:pdir$ ``` Yes, I've waited for minute and more

yes, it does after `^C` of `goreman run ...` it can't find process. like this: ``` nik@nik-msi@04:41:32:pdir$ goreman -f Procfile_db run stop p1 ^C nik@nik-msi@04:41:35:pdir$ goreman -f Procfile_db run stop...

It's also didn't said which bit endianness is used in the packets encoding.

What timestamp is used in Listener handshake packets? Until Listener received conclusion packet connection is not established and it's better not to allocate any resources. So the Listener doesn't have...