Volodymyr Makukha

Results 23 comments of Volodymyr Makukha

Unfortunately, we don't have any example projects with Next.js, but generally, I don't see any problems. BTW I would recommend you create PoC based on [ilc-demo-apps](https://github.com/namecheap/ilc-demo-apps/) - I believe it...

it's expected that microservice doesn't work without ILC context. you should: 1) run ILC locally - download the [repo](https://github.com/namecheap/ilc) and run it via `npm run start:no-apps`, this task run ILC...

Have you done every step here - [development process](https://github.com/namecheap/ilc-demo-apps/#development-process )? Looks like you forgot 3-rd step (Run `npm run build:all`) And JIC ILC related information about running is [here](https://github.com/namecheap/ilc/blob/master/CONTRIBUTING.md#install-and-setup-lde).

> @nightnei Looks like the tracking call is being fired twice :( > > First call: > > Second call: @wongasy good catch, thank you, fixed it - https://github.com/Automattic/wp-calypso/pull/68025/commits/838c802f44f4ffd4734aa9c90e2c5c1a880c254f The...

> @nightnei Thank you for the detailed explanations! I see one shortcoming with the current approach, and that is the tracking event is delayed till _after_ all the required server...

@wongasy [Done](https://github.com/Automattic/wp-calypso/pull/68025/commits/17164b717c46f1ad0e8c713f8ffe0dac077781b7) Regarding using `useEffect ` - I checked, and it's indeed not necessary, so I used just a simple component.

@Aurorum first of all, thanks for proposing PR with improvement. It's always cool to discuss any refactoring and make our codebase better. Of course it's my subjective opinion, but I...

@chad1008 I made two tests (with 2 domains), and 1 time I caught it. But, I tried to reload the congrats page and eventually I saw `2 mailboxes...`. Looks like...

@wongasy the lastest changes according to this discussion: p1708614763238729/1708610660.630559-slack-C06ELHR6L9J https://github.com/Automattic/wp-calypso/pull/87491/commits/0082ebe305f1ae9f8d3c12b3c401728bb1e34860 ![Screenshot 2024-02-22 at 16 44 51](https://github.com/Automattic/wp-calypso/assets/5598437/72ccdfa4-9336-42ee-ba60-5e7d0c2dea31) ![Screenshot 2024-02-22 at 16 45 05](https://github.com/Automattic/wp-calypso/assets/5598437/db1bb9eb-a596-4e17-9e47-7b7a0ace76ce)

@stephanethomas Also addressed white background for links