Nidhi Jaju

Results 13 comments of Nidhi Jaju

> The added cases look good. I think we should test that the service worker can observe the fetch abort and see the contents of the abort reason. I added...

> I'm missing a test that shows that the serialization happens on abort. I would expect something like a live JS object that increments a counter every time it's accessed....

FYI: Geolocation Sensor was fixed in https://github.com/w3c/geolocation-sensor/pull/53 and Idle Detection was fixed in https://github.com/WICG/idle-detection/pull/48 There is also an ongoing PR for EyeDropper: https://github.com/WICG/eyedropper-api/pull/25

We finally landed the Fetch PR (https://github.com/whatwg/fetch/pull/1343) as well, so I think we can close this issue now :)

@annevk I've made some changes to this PR and started a service worker PR as well (https://github.com/w3c/ServiceWorker/pull/1655). Would you be able to take a look?

Thank you, Noam and Domenic! I wasn't quite sure how to get the abort reason for cancelAlgorithm, but I've tried to incorporate all other feedback into the latest changes. The...

Hi @annevk, would you be able to take a look at this when you have time?

> I think it's good to go now though. Anyone any final feedback on this? It seems the tests are ready to land and I think we can assume implementation...

> @nidhijaju did you create a test for dynamically changing the CSP in combination with preload? I believe @noamr actually wrote a test for this case a couple years ago...

@noamr You're right. Although I don't have strong opinions on how early-hints should work with regards to CSP, I think the same argument, that we are using for allowing preloads...