Yves Junqueira
Yves Junqueira
It's been a while since I've written this, but if you could write a unit test demonstrating the fix, a PR would be great, yes.
hey @mipak thank you for the bug report. I didn't read other sections of the code but yes we should always return the buffer back. Want to send a patch...
Let's talk about MaxSearchQueries. How does it help you compared to using a low value for NumTargetPeers? It feels like during your experiments it would have been enough to set...
Torrent clients only need DHT to establish an initial connection to a swarm. After that they exchange peer information directly and the DHT is barely needed. In my mind, you...
If you were to change the default behavior, what do you think it should be? In other words, I think we should make things work out of the box without...
Can we reduce the number of changes and number of knobs from your proposed change? The DHT Config is already quite large. Can we maybe go with one or two...
Like we discussed, some of the memory usage you're seeing is normal given that GOGC=100, meaning that by default Go uses twice the amount of heap memory that it truly...
totalNodes - totalKilled nodes isn't a reliable measure of your active nodes. In theory at least, routingTable.numNodes is a better measure. Note that supposedly the number of nodes in the...
Hi @ltzMaxwell. It's been a while since I wrote that code, but I assume that `lookupFiltered` uses traverse, which is by itself the distance calculation method. Since the tree can...
I'd gladly accept a PR that implements this. Thanks