Nicolas ROGER comments

Results 7 comments of


                                            Nicolas ROGER

Float: legal instead of left

Same for `console.log` half of the time. Who even needs legal while coding anyway. +1 please fix or at least tell us how to remove it manually.

[Done] Allow html inside marker tip

I also think it's useful, I've made a PR just for this: https://github.com/spchuang/videojs-markers/pull/94/files

[Done] Allow html inside marker tip

It's been a while, but looking at the code, I believe you can do that: ```js markerTip:{ html: function(marker) { return ''; } } ```

fix: add exports section to package.json

Would be great to merge this PR

fix: add exports section to package.json

Would be great to merge this PR

No export from protobufjs/minimal causing errors in es6

Those PRs were open almost a year ago to solve the issue - https://github.com/protobufjs/protobuf.js/pull/1930 - https://github.com/protobufjs/protobuf.js/pull/1931

ts-node (ESM mode) incorrectly loads CJS types instead of ESM types for default exports with nested conditions exports

Running into this issue as well with: ## Specifications - ts-node version: 10.9.2 - node version: 22.14.0 - TypeScript version: 5.8.3 Other "workaround" is to add this flag: `TS_NODE_TRANSPILE_ONLY=true`, but...