Nick Tindall

Results 30 comments of Nick Tindall

I suspect this test never ran under the old surefire. See the test history, it only starts running on 27/5 after the parent POM upgrade (which upgraded to surefire 3.0.0-M6)...

@RobAustin No there's actually been no work done on this, I think the "few commits" might just be my original ignore commits (there's two because I incorrectly did it using...

> We should check that loopStarted is also called in event loop thread too. There's already tests for that, it is

Another thing to focus on IMO is API. Some things to consider - Having a consistent API across locks - Using standard interfaces (e.g. [Lock](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/Lock.html), and [ReadWriteLock](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/ReadWriteLock.html)) - Writing an...

Some other behaviours to consider - Persistence of locks, what happens when the holder dies? - Something like file locks that are automatically released would come in handy I think...

Apologies for pushing to the branch, but I just added a test to the test class that runs concurrent competing consumer threads and it doesn't seem to work. Perhaps I've...

Also some tests in ChronicleReaderTest

I merged some changes to hopefully shed some more light on this failure https://github.com/elastic/elasticsearch/pull/110956

I'm going to close this for now, it doesn't appear to have occurred since I merged the behavioural changes, if/when it does appear I hope that it'll look a bit...