Nikolay Yarovoy

Results 21 comments of Nikolay Yarovoy

I've just changed format and push changes to repository. So please check it.

I don't know what to do, It works for me.

I'm not running any tests. I fixed only one line. It works.

Hi, I don't think f64 is faster than f32. It is the same or slower. I.e. https://hugotunius.se/2017/12/04/rust-f64-vs-f32.html Also I believe there is no conversion f64 f32 (I use everywhere f32)....

> The `round_float` fn makes me think high precision was not critical here. Can you share what you do with that function? > > 1. Why is it necessary in...

> Btw would you prefer PRs to be smaller(focusing on single functions or at most, files) or current level? current level is OK, no problem :)

> [94e7b0c](https://github.com/nickspring/charset-normalizer-rs/commit/94e7b0c0a694b97c234d63f13276b76560f8730b) > > Seems to indicate that there was a regression. The way I changed it was to follow the upstream code as closely as a possible (instead of...

Thank you for issue. - `Rayon` is undoubtedly a good idea for parallel iterations, it should probably be implemented with feature flag. - Do you mean the hashing algorithm for...