Nick Geoca

Hi @Ralizada , would you be interested in helping contribute to the project? I can add you as a collaborator.

I created a branch for this, depricateSingleAsset. This isn't yet tested, so it is more starting out. Here are the [api changes.](https://github.com/OriginProtocol/origin-dollar/blob/depricateSingleAsset/contracts/contracts/utils/InitializableAbstractStrategy.sol#L244-L249) What is a good way to test this?...

What if you have two coins in threepool?

Ok awesome. I'll check more into that testing folder

This [liine of code](https://github.com/OriginProtocol/origin-dollar/blob/depricateSingleAsset/contracts/test/strategies/aave.js#L193) is producing the error below. It seems to work if it is `connect(governor)` rather than `connect(vault)`. Has anyone seen this error? ``` Error: invalid signer or...

Hey @tomlinton, this makes sense. I am wondering what a good workaround to this is? Maybe we can add a few functions in the MockVault and run proxy calls from...

It looks like it. Calling `await aaveStrategy.connect(vault).deposit(usdc.address, usdcUnits("1000"));` ends up calling a solidity function with a `onlyVault` modifier. ```solidity function deposit(address _asset, uint256 _amount) external onlyVault ```

Comparing compound.js and aave.js tests, it looks like even though they are both implementing the identical strategy interface, their tests are different. Do you want to put the liqudation test...

It looks like the [Mock Aave contract](https://github.com/OriginProtocol/origin-dollar/blob/master/contracts/contracts/mocks/MockAave.sol#L80) is not minting the collateral tokens during a deposit. It's taking the coins, but not creating collateral. I see this in the aave.js...

Oh... I think this is causing the errors- the aave.js test needs to use "A" tokens, rather than Compound "C" tokens.