JS Ng

Results 21 comments of JS Ng

RecordSpecificationElement from RecordSpecification (from 6.2.73) in particular is tricky because the recordLength is variable and depends on the recordID. recordID is a 32-bit enumeration with lots of potential record types,...

Per https://github.com/numpy/numpy/releases/tag/v1.18.4, the latest version of numpy that supports Python 3.5 is v1.18.4, we'll have to version-lock that dependency to maintain Python 3.5 support

Could I check what is the oldest version of Python 3 this package would be intended to support?

I am asking primarily because this would determine the main style and syntax to be used (e.g. `class DataQueryDatumSpecification( object ):` is required by Python2, but Python3 only requires `class...

Assuming there is no major prior use of open-dis-python that needs backward compatibility to be supported, I would recommend the following minimum versions: ### Python 3.5 This is the earliest...

As of time of this comment the following classes are affected: - [ ] DirectedEnergyAreaAimpoint - [ ] GridAxisDescriptorVariable - [ ] SilentEntitySystem - [ ] StandardVariableSpecification - [ ]...

Hopping back into this again. I looked at the record classes requiring padding again, and at the PDUs that use them. It looks like Transmitter PDU is one of the...

From the spec: ## 7.7.2 Transmitter PDU ### Table 175—Crypto Key ID record **Field name Bits Data type** Pseudo Crypto Key 0–14 15-bit unsigned integer Crypto Mode 15 1-bit enumeration...

## Handling Record Types The tricky part here: 1. Variable Transmitter Parameters record (VTPR) uses the Record Type to determine what the Record-Specific fields are. 2. This means VTPR will...

## Handling bitfields NET ID Record poses another difficulty, which is echoed in many places in dis7.py: handling bitfields. The canonical way of doing so in python is using the...