nik flahavan

Results 6 comments of nik flahavan

Retain Cycle CocoaAction

In the first code snippet you posted you are implicitly capturing self via a strong reference in the WorkFactory you're declaring. You are then explicitly capturing self via a weak...

Retain cycle in bind(to:input:)

https://github.com/RxSwiftCommunity/Action/pull/228 is available for your review whenever you get a chance!

Update GeoJSONSource.clusterProperties to support [["+", ["accumulated"], ["get", "sum"]], ["get", "scalerank"]]

@ZiZasaurus is there a way to express `[["+", ["accumulated"], ["get", "sum"]], ["get", "scalerank"]]` with the current state of the iOS mapbox SDK? I can't seem to figure out a way...

Update GeoJSONSource.clusterProperties to support [["+", ["accumulated"], ["get", "sum"]], ["get", "scalerank"]]

re-opened as a bug https://github.com/mapbox/mapbox-maps-ios/issues/1571

Emit step in readyToEmitSteps

I just ran into this issue today. When I try and emit a step in `readyToEmitSteps()` it gets lost. I'll try and make some tests that can prove this behavior.

Emit step in readyToEmitSteps

@mgray88 Were you using `CompositeStepper` by any chance? I can write a _quick and dirty_ test that fails when using a composite stepper. ```swift enum TestSteps: Step { case one...