Florent Daigniere

Results 300 comments of Florent Daigniere

Please don't mix formatting changes with code changes... it makes reviewing PRs such as this one very difficult

Aren't the iframes in freesites used for NIMs?

I haven't looked at the patch in details... but do we update IpToCountry.dat ? Where does it come from? https://dev.maxmind.com/geoip/geoip2/geolite2/ ? When was it last updated? Blocking peers based on...

I do believe that in any sane legal system, it's not that simple for LEO to operate overseas... Limits to jurisdiction exist for a reason... What's not sensible is to...

Performance wise, there is an argument to do exactly the opposite. Back in the days it was called p4p Maybe we should provide the option and pick a default based...

@xor-freenet > I had sent you an encrypted email with another threat model. If anyone wants to know about it please ask me personally. Seriously? contribute in a useful manner...

Looks good to me

I like the idea here... but as @bertm said, it's just not ready. What do we do with it?

Can't we use ThreadLocal for that?

AEADOutputStream talks about nonce[0] &= 0x7F but doesn't enforce it in its constructor; IMHO we want/need both