Mårten Blankfors

Results 45 comments of Mårten Blankfors

Note that the sBTC definition in SIP-021 is currently a draft. I don't expect any large changes to happen to the wire formats, but we do have some small changes...

Implementation note: We need to ensure the structure we store in StackerDB has a bounded size as discussed here https://github.com/stacks-network/stacks-core/pull/4659#discussion_r1560353035

> If signers see that a threshold has been reached and no approved key set, they may trigger a new DKG round. However, the key could have been approved but...

Closing this ticket given that the premise has been invalidated, and recent discussions have lead to a different direction in the signer development.

For context: This is the RPC endpoint we have added in the `next` branch to get sBTC ops: https://github.com/stacks-network/stacks-blockchain/pull/3511

@zone117x it turns out the burnchain op data has already been added to the event-emitter payload. Let me know if you encounter any issues with the format. This issue is...

> Everything LGTM! There are a few instances where it would be helpful to pluralize function names that now return states instead of one state. Good point. I've updated `get_signer`...

> The structure of this code is giving me a lot of pause. It seems that there are several places where the signer state can just be willy-nilly reset from...

I've updated now so that state reloads only happen in `signer::update_approved_aggregate_key` which is only called in `signer::refresh_dkg`, which in turn is only called from the main loop if no approved...

Closing this PR due to us going in a different direction with the signer.