Nesta Bentum
Nesta Bentum
Clean and ready to merge version is #608
### About 'Include max metric in JSON files and in the frontend'. What max metric exactly is this about? SimilarityMetrics is an attribute in `JPlagOptions.java` as well as `ClusteringOptions.java`. I...
Thanks, Timur - those were already some pretty helpful hints! I still have a few questions left regarding the max metric: - What is the relation between `SimilarityMetrix#MAX` and the...
@tsaglam that helps a lot, thanks! I have another follow-up question: is `JPlagComparison#similarity` semantically the same as the "average metric"? If so, the report viewer DTO creation is faulty right...
### About 'Revisit JSON file generation when comparing large submissions and remove code redundancy in JSON files' I implemented an approach to reduce the report's file size: Code lines in...
@dfuchss > 1. How shall the report viewer use multiple files? For now it can only handle the one json afaik, or am I wrong? What would be the workflow?...
@sebinside > @nestabentum I also welcome the idea of the lookup table but would propose creating one table per submission to keep the file structure clearer. The only argument against...
@tsaglam it should work. Do you have some more information on your concrete case?
@JanWittler all I know is that the `TokenList` is currently used to determine the matches of a comparison: https://github.com/jplag/JPlag/blob/0780fc49c5d37c70f172f9d8289ddc158b6de934/jplag/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java#L156-L171 The information on matches is then further used to highlight them...
@tsaglam this is good to go