Jens Pitkänen

Results 20 comments of Jens Pitkänen

I'm not yet sure when I'll do 3.0, so I'll leave this open for now. Thanks for the PR!

Yep, this is planned for [3.0](https://github.com/neonmoe/minreq#planned-for-300), since it would require changing the Response struct's public API.

I haven't given it much thought. Reqwest's solution certainly makes for a clean API, but I fear that would require quite a bit of code, and I'd rather keep minreq...

Good suggestion, seems useful and relatively straightforward to implement! I don't have time right now to add it though, but definitely in the future.

They're dropped on response, by design. Minreq isn't really supposed to be extremely fast or efficient\*, but minimal in code size (including dependencies). \* We'll take what we can get...

I tested this on a Linux system finally, and I can now confirm that the problem only occurs with the rustls backend. Unfortunately, it seems rustls does not support IP...

Yeah, I diagnosed this a little, and I'm pretty sure it's because the Location field in the redirect is relative. Weird that this hasn't come up before, but definitely a...

Yep, [here](https://github.com/neonmoe/minreq/blob/master/tests/main.rs#L97-L141). EDIT: To add to that, minreq does handle redirects to urls and paths that start with /, just not relative paths. And there's some fiddling related to how...

Multipart/form-data is its own format that presumably requires including something else than just the file buffer in the body. It's implemented by crates like [multipart](https://lib.rs/crates/multipart), which seems to need some...

It's been fixed now, rebasing onto the newest master should make the CI pass. The PR looks great!