Someshwar Tripathi comments

Results 36 comments of


                                            Someshwar Tripathi

[HOLD for payment 2023-11-06] [$500] [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event

![image](https://github.com/Expensify/App/assets/64629613/14669603-3b09-4551-b33d-281a991cf466) This is because this patch does not pass `{passive: true}` to the `addEventListener()` function for the `'wheel'` event

[$500] [ECARD TRANSACTIONS] Header in expense view shows `$%amount% request` instead of `$%amount% for %merchant%`

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Header in expense view shows $%amount% request instead of $%amount% for %merchant% ### What...

[$500] [ECARD TRANSACTIONS] Header in expense view shows `$%amount% request` instead of `$%amount% for %merchant%`

@fedirjh hi, we now pass merchant for reimbursable transactions also. Latest main code was updated in [this PR](https://github.com/Expensify/App/pull/34216) to always use merchant if available: https://github.com/Expensify/App/blob/a1fe671e94f69a694e2847a6b74685270149e991/src/libs/ReportUtils.ts#L2240 So a check for the...

[$500] [ECARD TRANSACTIONS] Header in expense view shows `$%amount% request` instead of `$%amount% for %merchant%`

I think the bug here is that the Header should be: 1. `$%amount% for %merchant%` -> if it has a merchant 2. `$%amount% for %comment%` -> if it merchant is...

[Violations] Update tagOutOfPolicy and taxOutOfPolicy

Hi, sorry for delay, I have updated the PR!   Noting a few things: - For multitags The app does not show all levels of tag show up. This is what...

[Violations] Update tagOutOfPolicy and taxOutOfPolicy

@cead22 looks like the backend was updated to show `Tag` instead of undefined for `tagOutOfPolicy`. So currently it shows as: Is this good?

[Violations] Update tagOutOfPolicy and taxOutOfPolicy

Here's the policy setup: It does not have multiple levels of tag. Video The Policy ID is `484377E4416A2AFE` if that's helpful https://github.com/Expensify/App/assets/64629613/7f2d49e1-db79-4e31-8f0a-c40a44ec6566 For Multiple Tags The violations are now shown...