Nell Hardcastle

Results 154 comments of Nell Hardcastle

> Seems to be an esbuild + next 12 issue. Beyond me to figure out whether it's a bug or something where we need to update a config. Webpack 5...

> 3. When a new release of the bids-validator is accepted on OpenNeuro, OpenNeuro slowly progresses through the deposited datasets and **re-validates** them. Thus, a data set that once validated...

Here's another example of this issue. https://github.com/OpenNeuroOrg/openneuro/issues/1564 I think the validator is double counting things like annexed files or other symlinks where the target is within the root of the...

Looks like recording is just incorrectly defined as optional here: https://github.com/bids-standard/bids-validator/blob/571767eb23b4b8cae133166d0fcb62a629c8f191/bids-validator/bids_validator/rules/file_level_rules.json#L519

@sappelhoff Indeed it should work if you specify it like `--config.ignore=99 --config.ignore=44`. Note you have to include at least two, since it expects an array for ignore configuration.

> Can anyone help me to solve this problem. The tests are throwing a warning that the columns of optodes.tsv are not defined ([see log here](https://github.com/bids-standard/bids-validator/runs/5000965191?check_suite_focus=true#step:8:1698)). But as they are...

Looking at #1359, it reads the TIFF into memory and creates a duplicate copy to validate the TIFF header. In the browser this is probably okay (ArrayBuffer works with shallow...

> Regardless of if the validator is run via browser or node we create a dictionary with all the files as keys in the `fileArrayToObject` function in `utils/files/readDir.js`. Filenames could...

> Forgot about this, ignored files are treated differently in node and in the browser. In node ignored files are never pushed to the fileList where as browser files get...

The existing CLI tests are in bids-validator/tests/cli.spec.js but most of the options are not tested (just with and without --json).