yichao_wang

grad update issue

1

https://github.com/tianheyu927/PCGrad/blob/c5fbd7c856526373828074f06875230f7f3ee79e/PCGrad_tf.py#L51 In first iteration grad_i is update to proj(grad_i), but it is not updated in grads_task list, so that in next iteration, we compute proj(grad_j), grad_i in taken into account...

Hi，thanks for your great works, and i have some questions about the formulation 10 - it says "in the last transition we introduced the explicit simplifying assumption ... which becomes...

https://github.com/bwanglzu/Maximal-Marginal-Relevance/blob/1d722ac72200d26d431d17a97dc354637075d4d1/mmr/mmr.py#L35