Nathan Villagaray-Carski comments

Results 4 comments of


                                            Nathan Villagaray-Carski

File-like objects are closed after uploading

@zachliu I added an init method with a cast to work around the mypy issue: ``` class NonCloseableBufferedReader(BufferedReader): def __init__(self, raw: IO[bytes], *args: Any, **kwargs: Any): super().__init__(cast(RawIOBase, raw), *args, **kwargs)...

sveltekit nodejs adapter: Allow passing config.kit.paths.assets dynamically from environment variable

This would be very helpful for us. Our deployment pipelines look like: 1. Build/Test/Deploy Staging a. Build Docker image b. Run tests on container c. Deploy container to staging env...

Button id prop not passed to tag when disabled

That would fix my specific issue, but I think users will expect all the props to be passed into the svelte:element tag when the button is disabled, since that's the...

Button id prop not passed to tag when disabled

Gotcha - what if we do something like this? https://github.com/themesberg/flowbite-svelte/pull/1339 Just opened the PR to show the change, I haven't tested it since I don't have the local dev environment...