Navid C. Constantinou
Navid C. Constantinou
After push I get the following error: ``` $ git push Enumerating objects: 2896, done. remote: fatal: pack exceeds maximum allowed size error: remote unpack failed: index-pack abnormal exit To...
I got an incremental compilation error/warning here https://github.com/CliMA/Oceananigans.jl/blob/b6dd1fa9b1d740f7d8cb4be116a24cbba0042f86/src/Architectures.jl#L23
We should make sure that multigrid solver works on GPU. cc @elise-palethorpe
Seems that https://github.com/CliMA/Oceananigans.jl/pull/2412/ suggests that this is the fastest way for grids that don't have regular horizontal spacing or have an immersed boundary. Yet, the free surface solver constructor falls...
Why in the tests for the implicit free surface we use a grid with `Ny = 1` and not `Flat` y? https://github.com/CliMA/Oceananigans.jl/blob/27f7d044619b4159154a5940443be1d3d843aa5b/test/test_implicit_free_surface_solver.jl#L84-L86 cc @elise-palethorpe
This needs work but following suggestion, I submit a PR and we all work together... :) Closes #678.
Is this just a placeholder? Or does indeed `ShallowWaterModel.bathymetry` supports non-trivial bathymetry?