Evan Goldenberg

Results 4 issues of Evan Goldenberg

Constant, classes, and modules that are defined on the example group do not leak into the global namespace. While doing this may not be a particularly good practice, it should...

We have some of these in our codebase: ``` @option :foo ``` Handle them gracefully, even though they are invalid. These were causing errors in VSCode, via Solargraph: ``` [WARN]...

**Current behaviour** If `redis-activesupport` is present, then only `ActiveSupport::Cache::RedisStore` is patched (for methods that it has), and `ActiveSupport::Cache::Store` is not patched. https://github.com/DataDog/dd-trace-rb/blob/210ed96858ff889a6d69339ba6fb112d7c68b621/lib/datadog/tracing/contrib/active_support/cache/redis.rb#L25-L38 **Expected behaviour** `ActiveSupport::Cache::Store` is always patched, because it...

bug
community

This is a known issue, described in the original pull: https://github.com/petergoldstein/dalli/pull/844 Here is a proof of concept for how this might be improved, by defering the flushing of responses to...