Tuan Nguyen comments

Repositories
Issues
Comments

Results 3 comments of


                                            Tuan Nguyen

Let modifiers implement epoch adjustment when composing recipes

> I like the idea of defining the advance_epochs method in the modifier class. However, note that the new method does not try to update all attributes w/ "epoch" in...

Let modifiers implement epoch adjustment when composing recipes

> I agree this is a definite improvement over the current approach. I believe the only missing coverage (which isn't properly covered by the current state either) is `update_epochs` in...

Let modifiers implement epoch adjustment when composing recipes

> I like the new approach, but shouldn't the standard advance_epochs in modifier.py reproduce the old behavior to be safe? The impl in modifier.py is for the abstract scheduled modifier...