Nathan Parekh

Results 7 comments of Nathan Parekh

Trying to deploy to Heroku from the master branch is also not working, also having to do with the address environment variable not being set. Can be fairly easily fixed...

Looked around a bit... looks like the address environment variable is only used for display (like on the web display). This seems like it's the commit that "broke" this: https://github.com/ottomated/CrewLink-server/commit/274560a823b37f62f62bac918d2c2e85e9f9a32e,...

@jgroffen - maybe the best option would be to fall back to the old behavior (using public-ip from npm) if ADDRESS isn't provided? Along with a log warning or something?

I'm super new at this but I'm starting to look at implementing something like that and I'm already realizing one place this could be really confusing... Heroku provides a PORT...

@jgroffen - Overall looks really good. The only thing that stuck out to me while trying it out with manual and using Docker was that something like `docker run -p...

@jgroffen Thanks for the explanation! I'll try to make #118 a little more clear once this is merged, then.

@bthulse - that workaround is the only way to do it right now (other than using a fork, such as the one from #119). #119 should add automatic detection -...