Nathaniel Herman

Results 7 comments of Nathaniel Herman

Bump on this PR! Also @patrickvonplaten wdym by "leave it here"?

Hey! I did most of the updates and will look at adding an integration test. On that note, AFAICT from here https://github.com/huggingface/diffusers/blob/main/tests/pipelines/stable_diffusion/test_stable_diffusion_inpaint_legacy.py#L352, the code is actually loading the non-legacy pipeline...

@Randolph-zeng hmm I'm confused by the linked issue, do you only get the issue for CFG outside of 6-7, or for any CFG? I only really use the default CFG...

@anton-l bump on my question for the unit test, I just want to make sure I'm understanding correctly before I add my own unit test

[red_cat_sitting_on_a_park_bench_repaint.npy.zip](https://github.com/huggingface/diffusers/files/10212497/red_cat_sitting_on_a_park_bench_repaint.npy.zip) ![red_cat_sitting_on_a_park_bench_repaint](https://user-images.githubusercontent.com/5169954/207170224-d2ba2d67-a211-4593-bec8-92bf0953c9f6.png)

@anton-l makes sense! I've added the test and attached the npy file as a comment on this PR — IIUC from the docs, someone would need to upload that npy...

@anton-l perfect, it should be good for final review now!