natebundy

Results 7 comments of natebundy

Sounds good, but we'll still need a way to check if attrs.uiSelect is an object literal, correct? Trying to watch it in that case will throw an error. try/catching angular.fromJson...

The latest revision fails several tests but seems to work in practice. I'll add some tests for the new functionality soon and check if the existing tests are failing for...

It turns out those tests were failing for good reason and my instincts were right to call select2 with the initial options. All tests passing now, just need to add...

@billyvg @mydea Is it possible for you all to run this code outside of the Angular zone to avoid this issue entirely? "Third-party libraries commonly trigger unnecessary change detection cycles...

Thinking about this more, since Sentry is initializing outside Angular, you could possibly look for the global Zone object existing and call things in Zone.root.run(() => {...}) to avoid change...

Thanks, I'll give it a try! I just found out Angular is experimenting with zoneless change detection, so hopefully at some point in the very far future this will stop...

Signal inputs on CDK Dialog would greatly help on my project as well. Currently, we have to `setInput` observables on to the component ref, which feels like an anti-pattern: ```javascript...