Natan

Results 7 comments of Natan

Hi @diegohaz thanks for the feedbacks! > I still haven't looked deep into the code, but testing the component, I noticed some bugs or missing features Thank you for looking...

> But after a glance, I wonder if we can simplify the state a little bit. Composite already uses Collection underneath. Do you think we can use the tree.items state...

I think there might be some implementation problem here. I'll try to answer based on current implementation, so we can see what can be better. > Can we set shouldRegisterItem:...

> This is an issue only with the flat tree because we can't pass data from the parent items to the children through React Context, right? Yes it is >...

> Thanks for rebasing the PR. Just in case you're wondering, the failing tests on React 17/16 are related to this code: > > https://github.com/ariakit/ariakit/blob/1358f5294c2ba24022681378c511059efe118fa7/packages/ariakit/src/collection/collection-state.ts#L97-L102 > > I'm not sure...

> Hmm! Weird. They shouldn't fail. setTimeout works as a debounce there so it's not called multiple times when there are multiple updates at once. At least on React 18,...

I'm sorry, I was playing around with the example [here (APG)](https://www.w3.org/WAI/ARIA/apg/example-index/tabs/tabs-manual.html) without reading the specification 😅 My prior assumption: - If there is a tabbable element inside TabPanel, focus should...