Andrey Andreev
Andrey Andreev
Issue is still open, so no. I think I remember making it not add spaces, but it does try to escape identifiers and everything separated by commas is treated as...
Some improvements have been made, but it's still not flawless ... I'm not sure it can ever be. If anybody has feedback - please comment.
Haven't looked into it yet, just referencing #3847 as relevant.
This is targeting 3.1.0, where we'll have a few minor BC breaks like this, so ... no, you don't need to do that.
Sorry all that I've left this one to rot. The Profiler has always been just an uninteresting chore for me. @gxgpet I don't know if there are still people interested,...
This is parameter creep ... It may look inconsistent, but a better option would be to just have `having_like()`, `having_not_like()`, etc. And you must follow the [styleguide](https://www.codeigniter.com/user_guide/general/styleguide.html).
You're still ignoring the styleguide ...
Yes, there are still some spaces left in on lines 1100, 1171 (shown in diff with darker green). And there's more significant stuff code-wise, but it will probably result in...
Yes, all of CodeIgniter doesn't match PSR-2 rules. We have our own [styleguide](https://www.codeigniter.com/user_guide/general/styleguide.html), referenced in the [contributing guide](https://github.com/bcit-ci/CodeIgniter/blob/develop/contributing.md), which you should read before reviewing others' work.
In relation to #4200 ... let's leave `show_error()` as is for now. Changing it to just throw an exception may not be as good as I initially thought. It may...