Nan Yu

Add a new GitLab service to support creating a commit status and creating a comment to the associated merge requests

2

There is no GitLab integration for status update. The only way is to configure the webhook to send a REST request, but it only supports one single REST call. If...

Add a new Bitbucket service to support creating a commit status and creating a comment to the associated pull requests

1

There is no Bitbucket integration for status update. The only way is to configure the webhook to send a REST request, but it only supports one single REST call. If...

Currently, the notification subscription annotation key is hard-coded with the `notifications.argoproj.io` prefix. It would be more flexible if we can use a different prefix in the annotation. Same for the...

The notifications engine library only supports prometheus metrics: https://github.com/argoproj/notifications-engine/blob/master/pkg/controller/metrics.go#L37. It should support other metrics agents, such as open-telemetry.

Currently, the notification engine leverages the [Logrus](https://github.com/sirupsen/logrus) library to log errors. It is non-trivial to extract the errors for further processing. One possible solution is to add a configurable callback...

Fix a race condition on reconciler finalizer removal

3

Previously, the reconciler is responsible for removing the reconciler finalizer from the RSync object, but if the reconciler fails to update RSync to remove the finalizer (e.g. the reconciler is...

test: add test coverage for missing permissions

3

There are multiple issues with missing permission, though they all share the same KNV2004 error code. This commit adds test coverage for the following scenarios: 1. A GSA doesn't exist...

refactor the source spec validation

1

This commit covers more failure scenarios with the redudant fields validaiton.

git-sync v4 fetches the HEAD of the remote default branch instead of `master` if --ref is not specified

6

This is a breaking change in git-sync v4. In git-sync v3, if neither `--branch` or `--rev` is specified, it fetches the HEAD commit on the default `master` branch. In git-sync...

git-sync v4 no longer supports abbreviated commit SHA

12

In git-sync v3, `--rev` can point to an abbreviated commit SHA. `git rev-parse ` works because it clones the repo first. Then `git rev-parse` is able to parse the full...