Naser Al Madi comments

Results 14 comments of


                                            Naser Al Madi

error in emtk/util/_get_stimuli.py

Thanks for sharing this @najam-tariq! Would you like to make a pull-request with the suggested fix?

updated get_stimuli.py

It looks like the change broke the tests, can you check the test that failed and possibly update it, if needed? Here's the failed test output: =========================== short test summary...

Download function downloads the EMIP dataset along with this toolkit and the corrected dataset

Good catch! It was a temporary solution until we create a repo for datasets. A good solution until then is to add only the zipped EMIP dataset to the datasets...

Add a dynamic integration of srcML into the add_srcML function

Good questions, I think pip is mostly for Python packages so I doubt it will be there. Maybe you should ask here: https://github.com/srcML/srcML

Complete community profile

Great work, thanks @jhimel22

add Contributing section to readme

Thanks @jhimel22

add_tokens_to_AOIs does not work when AOI kind is line instead of sub-line

Hello Elliot and Tom, Adding an error message is not a solution for the problem, it requires adding code to allow for an entire line to be processed as an...

add_tokens_to_AOIs does not work when AOI kind is line instead of sub-line

Thanks @jhimel22 You should create a pull request for this fix, if possible.

Merge draw_trial implementations into one simple function

Thanks @jhimel22 You should create a pull request for this, if possible.

Create a web documentation EMTK

This looks great, thank you! I will talk to you in person about some comments and questions.