nakamura shuta comments

Results 4 comments of


                                            nakamura shuta

[BUG] set-cookie twice / header folds

Should I implement the get_all function in Headers (headers.rs) with the following specification? ``` Return all values of the `Set-Cookie` header in the `Headers` object with Returns them as a...

Implement get_all function to return non-folding set-cookie headers

The workerd code I used as reference for implementation made an error when a header other than `set-cookie` was specified, so I implemented it as is. https://github.com/cloudflare/workerd/blob/a265d5c22bf2a6bc6394aa54db517ff86d6c788c/src/workerd/api/http.c%2B%2B#L229-L242

Implement get_all function to return non-folding set-cookie headers

@kflansburg Yes, I think that is the simplest way. I implemented it that way. (Like other functions, such as “entries”.) If you have any suggestions for improving this implementation, I...

Implement get_all function to return non-folding set-cookie headers

@kflansburg > This looks great! Were you able to test this? I created the following application under the example directory and verified its operation with curl. (Not git committed) ```rust...