Gereon Kremer
Gereon Kremer
> Doing this just for one secret seems odd, wouldn't it be better to have some loader or something that does the file reading on the fly? You think of...
I moved the wrapper to `helpers.php` and check whether the file exists. I'm not sure where `env` even comes from. I've just seen this file secrets in the `mariadb` container...
I added a unit test. Given that we use this `env()` everywhere else, it seems more consistent to keep using it.
@MyIgel can we make some progress here? :-)
Maybe I just misunderstood the intended workflow. If I understand correctly, the following happens: - I create an angel type that requires the ifsg - an angel joins and enters...
[Disclaimer: I'm looking at a version from end of August right now... not sure how much this has evolved] My impression is that there is a conceptual confusion / entanglement...
Yeah, I figured that the core reason would be historical :-) My proposal would be to make it so that angel types can have multiple requirements (introduction, drivers license, ifsg,...
I have the same issue, and it is pretty annoying. Is there any workaround?
I've tried to debug this (https://github.com/nafur/update-pr-branch), but this just seems to work as expected. I'm wondering whether the reviews are in a different order than expected (and documented)... Is it...