n2h9
n2h9
Hey hello, :wave: :innocent: ! Would appreciate if you @devhindo by chance have some comments on this :blush: thank you :bowing_woman:
> I merged these conflicts, @n2h9. I think that I did it correctly, but I see that the integration test is failing... 🤔 right, let me double check on this...
> > I merged these conflicts, @n2h9. I think that I did it correctly, but I see that the integration test is failing... 🤔 > > right, let me double...
> > > I merged these conflicts, @n2h9. I think that I did it correctly, but I see that the integration test is failing... 🤔 > > > > >...
> > > .Config File "meshsync_config" Not Found in "[/home/runner/.meshery]\ > > this is related to this comment in [internal/config/config.go:16](https://github.com/meshery/meshsync/pull/386/files#diff-54c7c1af5fa8d5db4dc49f0e8e80e93ba2b1183ba4d5c9e2e5729e6deae6a3cdR16) > > I inherited this change from this pr: #361...
> I will probably need to add a code here, which creates the folder $HOME/.meshery. I mean not before test, but in the meshsync itself. And also there are fresh...
> to fix a cyclomatic complexity in main, as it is now huge after my changes (it was big but now huge 😄 ) I started to do it, and...
Added couple test cases which do checks when output mode is file;
I did some debugging around this issue. Looks like nighthawk returns to the meshsery server next response: ``` "Unknown failure. See Nighthawk Service logs. Make sure the URI is well...
Looks like there is no error if build nighthawk from the latest version from master. Need to continue this investigation. Build this binaries https://github.com/layer5io/getnighthawk/tree/master/apinighthawk/bin from https://github.com/envoyproxy/nighthawk master, because there is...