Niklas Gehlen

Results 10 comments of Niklas Gehlen

At namespace.so, we're a few folks from the original Boq team at Google. We were also missing a public equivalent of Boq, so we built https://github.com/namespacelabs/foundation and are using it...

Maybe related: Adding an edge twice does not return `false` but leads to a panic when sorting the graph. ```golang graph := toposort.NewGraph(2) graph.AddNode("a") graph.AddNode("b") graph.AddEdge("a", "b") graph.AddEdge("a", "b") graph.Toposort()...

> This could also be a `driver-opt` maybe? Thanks! I like this path, as it allows finer granularity when selecting the new behavior (per driver vs per env). From what...

@tonistiigi @crazy-max Thanks for taking a look at this! From what I can tell, I addressed all your suggestions. Is there anything left to do to make this PR ready...

> Can you squash your commits please? > > Also would be nice to have integration tests in https://github.com/docker/buildx/tree/master/tests if you can or can be follow-up > > Thanks! Sure!...

@crazy-max Could you help me re-trigger the validation workflows?

> @crazy-max Could you help me re-trigger the validation workflows? Thanks! Let me know if there is anything else I can help with here 🙏

> It needs a rebase with changes introduced recently sorry 😅 See also review, I tried to push changes to your branch but looks like you don't allow edits by...

> I'm fine taking this change. Can you sign the commit to get CI running. Done ✅

cc @eddumelendez To add more context, this issue is causing a race condition in Testcontainers: Testcontainers [skip](https://github.com/testcontainers/testcontainers-java/blob/main/core/src/main/java/org/testcontainers/images/RemoteDockerImage.java#L75) Docker pulls if an image is already cached. However, two concurrent pulls for...