Mark Karatovic
Mark Karatovic
No never resolved this - ended up using a different clunkier approach if I recall (other than TP's) which is a shame. Better late reply than never.
@Tarmil My impression was that the "With" syntax simply compiles into a similar form as having to create the record and assigning the fields yourself. In this case type inference...
#3 fixes point 1 (arrays) without library changes upstream
Its been some time since I've done anything with the SDK to be honest as well so my knowledge is outdated too - it used to do Reflection.Emit but I...
Nice work @mishun. I note that there are conflicts that still need to be resolved. Let me know when this is ready to review. Thanks!
> It's rebased onto current master (so it could be merged smoothly into master if necessary) Understand that. But the way the PR is setup I can't merge it into...
Yep I'm ok with that. We just bump the version of the library after significant testing. The Protobuf-net library it is pointing to isn't that new in any case. If...
Looks much better. Will review when I get the chance. Main thing that comes to mind is the Proto representation of the List, Set and other surrogates.
I do have a question that came up in my testing of this code. the answer may be obvious but I'm not seeing it. Given: ``` type [] TestRecordWithNestedCollections =...
> On the topic of zero values: protobuf-net seems to handle empty string ok (it comes out on the other side as empty string, not null). Is manual handling for...