mvdebolskiy

Results 78 comments of mvdebolskiy

@ekluzek I was able to build and run the model with the commits above (both with `use_excess_ice=.true.` and `.false.`, cold start and from finidat, resubmits also worked). I haven't resolved...

I've checked TWS variable. It gets changed with the amount of excess ice, as expected. So, this one passes.

@ekluzek added log and fixed history fields. Also, maybe #1819 should be closed. When the initial data interpolation is used you automatically get logs like: `Skipping : VARNAME is NOT...

@ekluzek I added that line, to have a reminder to check if `watsat` has to be scaled somewhere else in the same manner it is done here, but so far...

Just a note. Since excess ice PR has been accepted: - all the columns will get the same amount of excess ice within a grid cell when initialized with a...

Though maximum amount of subsidence, considering current initial volume is less than 1 m. So, it might be ok to not include elevation update for now.

@ekluzek Is this because excess ice is read before `nbedrock` is read from a restart? I do not remember encountering this when I was testing running from `finidat` or hybrid...

> @mvdebolskiy the fix is straightforward, see what I did in [212e104](https://github.com/ESCOMP/CTSM/commit/212e10476a64911da1ca9dff9f1a172515c4707a) which I just pushed. Let me know if you see any issues with it... No issues. Nice catch,...

@ekluzek I have a suspicion that the fails were caused because some compilers did not like when you add anything to the `spval`. In `initVerticalMod` we have loops like [this...

@ekluzek I will run the latest on fram during the weekend. Is it even possible for me to assign myself to the issue on this repository? I don't see a...