Alexis Glass
Alexis Glass
Sorry for the delay. I'm really grateful for your thoughtful feedback and I'm sorry I haven't had time to respond properly. I'll take a look soon.
> Thank you! > > I added some suggestions since I think the `static inline` is redundant, and the `static` can be removed. > > Klick through them if you...
I'd be most interested in (in order) 4, 11, 14/15.
Introduced to the snapchat fork since this list was published, but I would be interested in their work on supporting futures.
I just noticed that the test-suite unit tests for wasm/ts are not being run on the snapchat CI. I hope we can get it running here.
The unit tests are running locally. So all that remains (??) for this PR to complete the basic wasm support, I think, would be to run the wasm tests on...
I've added the text sort example from the snapchat repo (as it was adapted from dropbox/djinni). It's building and running ok for me locally. So, still remaining - [x] build...
 WASM/TS tests are now running in a headless chrome instance, and failing test output is captured from the browser and dumped to the terminal.
> DjinnniModule.ts/js files > Could they be 'generated' by the generator? As far as I seen, those are just one liners, one for js one for ts, or do I...
> I have a super busy week ahead, so please be patient if I am not immediately available for further actions in the upcoming days. I'll probably slow down a...