Marc Dougherty

Results 18 issues of Marc Dougherty

Adam, as per our discussion earlier today, here's a solution that reuses the TokenSource between multiple calls. Its only really good for a single `audience`, but i think it helps...

api: run
samples

This PR should shake out any tests that need changes prior to the release of go1.22, which introduces a change to the way loop variables are scoped. see https://go.dev/wiki/LoopvarExperiment for...

samples

the following packages do not use fully qualified module names, which results in 'ambiguous import' errors. - [ ] ./compute/quickstart - [ ] ./internal/gomodversiontest - [ ] ./appengine_flexible/static_files - [...

type: bug
priority: p2
triage me
samples

several tests use `fmt.Print` and variants that appear to be confusing testing with `gotestsum`. these appear as status `(unknown)`, due to parsing errors from print statements that do not end...

type: bug
priority: p2
triage me
samples

With recent changes to kokoro runners, we may no longer need so much of the Trampoline scaffolding. there are some cases (e.g. the `trampoline_cleanup.sh` script) where trampoline is concealing other...

samples
stale: old

Many of our samples require an `io.Writer` argument, which is used so we can capture the output of the sample. This is a bit awkward, and impedes the goal of...

type: process
samples
stale: old

As shown in the following [test results](https://fusion2.corp.google.com/invocations/80cb8721-8978-4eec-ab1c-02cf7f88cd8b/targets/github%2Fgolang-samples%2Fvideointelligence;config=default/tests), VideoIntelligence tests appear to be receiving an empty response, resulting in test failures like: ``` Failed video_analyze_test.go:33: TestAnalyzeSpeechTranscriptionURI failed: wanted cultural, got video_analyze_test.go:33:...

priority: p2
type: cleanup
triage me
samples
stale: old

go 1.21 includes an experiment to evaluate a proposed change in variable scoping of for loops: https://github.com/golang/go/wiki/LoopvarExperiment before 1.22 is released, we should run all tests in this repo with...

priority: p1
status: investigating
type: feature request
samples

The images we use to run these tests, which live at gcr.io/golang-samples-tests/go119 (et al), should have a more well-defined maintenance plan. We currently build them as needed, and do not...

priority: p2
type: feature request
samples
stale: old