Kent Ross

Why is this an issue with digestpp? None of the strings "NOMINMAX", "windows.h", or "windef.h" appear anywhere in this repository, case insensitive. This does not seem like a valid issue.

Is there a blocker for this PR?

`/characters/{character_id}/` now reflects `corporation_id`, which is great. The XML API is still required to get exact time of death, but only once (or rather, once per biomass in the event...

there it goes again

yeah, i already have LLVM-coverage tools installed. i have the whole LLVM-19 suite, so i was eventually able to figure out getting a coverage report directly with the underlying tools,...

#1

suggestion: preserving unknown fields (e.g., read message with unknown fields, modify, write: new written message preserves unknown fields unchanged). many apis also allow detecting and explicitly dropping unknown fields.

here are the relevant benchmark outputs for my available machines, diffed with `critcmp`: amd 7950x: ``` group bounded master ----- ------- ----- varint/large/encode 1.00 411.1±1.95ns ? ?/sec 1.18 485.8±0.56ns ?...

i have a macbook sitting around, with an intel i7-9750H: ``` group bounded master ----- ------- ------ varint/large/encode 1.15 1191.2±0.71ns ? ?/sec 1.00 1038.3±0.31ns ? ?/sec varint/medium/encode 1.42 725.6±4.22ns ?...

if you insert before `let decoded_value = ...` the following debug line: `println!("{buf:02x?}");`, you will see that `encode_varint` has *appended* the bytes of the varint value `16384` to a buffer...