Mark Muhleder

Results 5 comments of Mark Muhleder

We're seeing the same issue getting dragula angular to work with nested items, what's working for us is to amend drake.containers and drake.models when the DOM element is destroyed (which...

Seeing the same on Flutter 3.3.0 if size is not set on app startup. Using this as a workaround. ``` doWhenWindowReady(() { Size mySize = appWindow.size; appWindow.size = Size(mySize.width, mySize.height...

`lineCount` here https://github.com/flutter/engine/blob/87eff25909559e86f1e9f87de1516cbdc2ca82ab/lib/web_ui/lib/src/engine/text/measurement.dart#L590 gets capped at `maxLines` if set, so `height` and `naturalHeight` always end up being equal which causes `didExceedMaxLines` to always be false. https://github.com/flutter/engine/blob/7bda396b0f4778a2364f43f3951ef42f7bce6228/lib/web_ui/lib/src/engine/text/paragraph.dart#L308

It looks like `LinesCalculator` stops measuring when it hits the `maxLines` limit (would make sense for performance) which could be why `lineCount` gets capped. https://github.com/flutter/engine/blob/87eff25909559e86f1e9f87de1516cbdc2ca82ab/lib/web_ui/lib/src/engine/text/measurement.dart#L842

Incidentally `DomTextMeasurementService` does provide the correct `naturalHeight` so a quick fix for anyone who needs it and is comfortable compiling their own engine is to add a `style.maxLines == null`...